Register  It's Free! Wednesday,   March  10,   2010
User Name Password
  Downloads   Modules

Login
Username:

Password:

Remember me



Lost Password?

Register now!
Main Menu
Who's Online
7 user(s) are online (1 user(s) are browsing Forum)

Members: 0
Guests: 7

more...
Please Read This
All my modules require users to be registered to add listings or to reply to a listing.
There are parts that NEED a user ID. to work properly.

All reputable websites DO NOT allow anonymous users to add anything, even on the
Xoops site you need to be registered, there are many reasons for this.

You may be able to hack the module to work with non registered users, it will probably not be easy, and I do not support this. I'm sorry but thats the way it is.
   All Posts


(1) 2 3 4 ... 200 »


GreenFlatDog
Listing added without category
#1
Zoner
Joined:
2008/9/25 11:46
Posts: 55
Offline
It seems possible to add a listing without selecting a category.

In this case it does not show in any category.

If the submitter gets to it via 'View your listings' and opens it for editing, then saves it (even without changing anything), the listing acquires the first category in the selection box. If this re-saving isn't done then the listing won't show in any category.

I've had a look at addlisting.php and I can't work out how to trigger the validation arrangements to ensure a category selection is made. Without some help for users on this I think Admins will find users complaining, or worse going elsewhere.

Is validation impossible? (we will have to live it it)
Is it really tricky? (I'll leave it you!)
Do you know this can be fixed but you're busy on other things? (I'll spend some more time on it)

Regards,

Posted on: Today 12:43
_________________
GFD
Transfer the post to other applications Transfer


GreenFlatDog
Labels - Changing company information
#2
Zoner
Joined:
2008/9/25 11:46
Posts: 55
Offline
There are a couple of strange labels assigned in editcomp.php

Line 215:
Labels the button at the bottom of this form as:
_JOBS_MODIFANN - defined in English as 'Modify your job listing'

Suggest changing it to the value from the legend (line 110):
'_JOBS_EDIT_COMPANY' - defined in English as 'Modify your Company Information'

Line 298:
Does the re-direct with message:
'_JOBS_JOBMOD2' - defined in English as 'Job Listing selected has been modified'

Suggest changing it to:
'_AM_JOBS_COMPVALID' - defined in English as 'Company Info Modified Successfully '

Regards,

Posted on: Today 10:55
_________________
GFD
Transfer the post to other applications Transfer


GreenFlatDog
Link to add photo
#3
Zoner
Joined:
2008/9/25 11:46
Posts: 55
Offline
john,
This link shows when a user is viewing their resume even when the module config is set to zero photos. If you feel it better to suppress the link when the Admin has chosen zero photos then in index2.php ...

line 604 replace with:
// START 2 - prevent 'add photos' link when module config says no photos - GreenFlatDog
if (($premium && $xoopsModuleConfig['jobs_nb_pict'] == 0) || (!$premium && $xoopsModuleConfig['jobs_not_premium'] == 0)) {
$xoopsTpl->assign('add_photos', "");
} else {
$xoopsTpl->assign('add_photos', "<a href="../$mydirname/view_photos.php?lid=".addslashes($lid)."&uid=".addslashes($usid)."">"._JOBS_ADD_PHOTOS."</a>"); // this line was on its own before !!
}
// END 2 - prevent 'add photos' link when module config says no photos - GreenFlatDog


and insert at line 39
// START 1 - prevent 'add photo' link being shown when config says no photos - GreenFlatDog
if (!$gperm_handler->checkRight("jobs_premium", $perm_itemid, $groups, $module_id)) {
    $premium = 0;
} else {
    $premium = 1;
}
// END 1 - prevent 'add photo' link being shown when config says no photos - GreenFlatDog


Regards,

Posted on: Today 7:38
_________________
GFD
Transfer the post to other applications Transfer


GreenFlatDog
Resume photos
#4
Zoner
Joined:
2008/9/25 11:46
Posts: 55
Offline
Two issues:
- I can't see how an Admin gets access to a resume's photos. If you edit a resume as Admin there is no link to that user's gallery. There may be misunderstandings about suitable photos in some professions! Admins may need to intervene quickly.

- When a user deletes a photo it is removed from the resume gallery but seems to stay on the server. This might prove a challenge to 'clean up' when space becomes an issue.

Sorry not to be offering solutions here.
Regards,

Posted on: Today 7:16
_________________
GFD
Transfer the post to other applications Transfer


GreenFlatDog
Company users - validation
#5
Zoner
Joined:
2008/9/25 11:46
Posts: 55
Offline
It would be nice to give users some help after entering an additional company user which turns out not to work.

They might mispell the name, it might not exist or where it does exist it may not have submit permissions. At the moment editcompany.php takes the entries for additional company users, says 'thanks' and if an entry is spelt wrong it doesn't update the DB but leaves the user wondering what's happened.

If the entry is OK it will update the DB but if this person hasn't got submit listings permission then they will still not be able to add a listing - although their colleague might be telling them, 'I've just added you to the system so you can now add listings.'

I particularly like the additional company user feature so I've had a go at trying to help get them added easily. There are three blocks needed in editcomp.php and working from the bottom (so the line numbers make sense) they are:

lines 250 & 251 replace with:

// START 3 - check new entries for company users are OK - GreenFlatDog
// defines should go to language files
define ("_JOBS_USER_NOT_THERE", " was not found. Please check your entry and try again<br />");
define ("_JOBS_USER_NO_PERMISSION", " doesn't have permission to submit listings<br />");

$comp_users = array();
// get user id for the name entered for company user 1
if ($comp_user1 == "") {
    $comp_userid1 = "";
} else {
    $comp_userid1 = jobs_getIdFromUname($comp_user1);
    // put name, id, what's entered and problem into an array
    $comp_users[$comp_user1]['name'] = $comp_user1;
    $comp_users[$comp_user1]['id'] = $comp_userid1;
    $comp_users[$comp_user1]['entry'] = "&cuser1=";
    $comp_users[$comp_user1]['prob'] = "&prob1=";
}
// get user id for the name entered for company user 2
if ($comp_user2 == "") {
    $comp_userid2 = "";
} else {
    $comp_userid2 = jobs_getIdFromUname($comp_user2);        
    // put name, id, what's entered and problem into an array
    $comp_users[$comp_user2]['name'] = $comp_user2;
    $comp_users[$comp_user2]['id'] = $comp_userid2;
    $comp_users[$comp_user2]['entry'] = "&cuser2=";
    $comp_users[$comp_user2]['prob'] = "&prob2=";
}
if (!empty($comp_users)) {
    // we have checks to make
    $gperm_handler =& xoops_gethandler('groupperm');
    $errs = "";
    foreach ($comp_users as $u) {
        if ($u['id']) {
            // we have user id for name entered
            $xu = new XoopsUser($u['id']);
            $grps = $xu->getGroups();
            if (!$gperm_handler->checkRight("jobs_submit", 0, $grps, $module_id)) {
                // no submit permission
                $errs .= $u['entry'] . $u['name'] . $u['prob'] . "p";
            }
        } else {
            // no user id for name entered
            $errs .= $u['entry'] . $u['name'] . $u['prob'] . "n";
        }
    }
    if ($errs) {
        // we are going to re-open the form and request corrections
        // add to the query string the comp user(s) with their usernames and what problems they have e.g.
        // name1=xyz and prob1=p (no submit permission) or prob1=n (not there)
        redirect_header("?op=ModCompany&amp;comp_id=".addslashes($comp_id . $errs)."", 5, "Correction required");
        exit();
    }
}
// END 3 - check new entries for company users are OK - GreenFlatDog    


lines 195 to 199 replace with:

// START 2 - check new entries for company users are OK - GreenFlatDog
// if we have been re-directed because of problems add some info to the label adjacent to the input box
// defines should go to language files
define("_JOBS_COMP_USER_NOTTHERE", " is not there - check spelling");
define("_JOBS_COMP_USER_NOPERM", " does not have permission to submit listings - contact administrator");
$alert = "<br /><span style='color:#f00'>%s%s</span>";
        if ($cuser1) {
            $prob = ($prob1 == "n") ? _JOBS_COMP_USER_NOTTHERE : _JOBS_COMP_USER_NOPERM;
            $alert1 = sprintf($alert, $cuser1, $prob);
            unset($prob);
        }
        echo "<tr>
        <td class="head">"._JOBS_COMPANY_USER1.$alert1." </td><td class="odd"><input type="text" name="comp_user1" size="30" value="$comp_username1"></td>
        </tr><tr><td class="head">"._JOBS_USER1_CONTACT."</td><td class="odd"><textarea name="comp_user1_contact" cols="25" rows="6">$comp_user1_contact</textarea></td>";

        echo "</td><tr>";
        if ($cuser2) {
            $prob = ($prob2 == "n") ? _JOBS_COMP_USER_NOTTHERE : _JOBS_COMP_USER_NOPERM;
            $alert2 = sprintf($alert, $cuser2, $prob);
            unset($prob);
        }
        echo "<tr>
        <td class="head">"._JOBS_COMPANY_USER2.$alert2." </td><td class="odd"><input type="text" name="comp_user2" size="30" value="$comp_username2"></td>
        </tr><tr><td class="head">"._JOBS_USER2_CONTACT."</td><td class="odd"><textarea name="comp_user2_contact" cols="25" rows="6">$comp_user2_contact</textarea></td>";
// END 2 - check new entries for company users are OK - GreenFlatDog


lastly insert after line 152:

// START 1 - check new entries for company users are OK - GreenFlatDog
// check if we have arrived after a re-direct due to problems with company user entries
// defines should go to language files
define("_JOBS_PLS_CORRECT", "*** There was a problem with your modifications - please correct ***");            
if (isset($_GET['cuser1']) && $_GET['cuser1'] != "") {
    $cuser1 = $_GET['cuser1'];
    $prob1 = $_GET['prob1'];
    $alert_message = _JOBS_PLS_CORRECT;
}
if (isset($_GET['cuser2']) && $_GET['cuser2'] != "") {
    $cuser2 = $_GET['cuser2'];
    $prob2 = $_GET['prob2'];
    $alert_message = _JOBS_PLS_CORRECT;
}
        echo "<span style='display:block; text-align:center; color:#f00'>" . $alert_message. "</span>";
// END 1 - check new entries for company users are OK - GreenFlatDog


There may be an altogether better way to validate the input on this form but as a quick fix this seems to work OK

Regards,



Posted on: Today 6:58
_________________
GFD
Transfer the post to other applications Transfer


john
Re: Classifieds 2.2 Released on Feb 27, 2010
#6
Webmaster
Joined:
2004/10/6 16:13
Posts: 832
Offline
Do you have any errors or bad queries(in red) listed with debug turned on?

Did this just happen or did you change something and then it happened?

John

Posted on: Yesterday 16:51
Transfer the post to other applications Transfer


bumpeboy
Re: Classifieds 2.2 Released on Feb 27, 2010
#7
Just popping in
Joined:
2/15 13:34
From London
Posts: 4
Offline
Hi John i have closed my site after a major error.

1. The adverts under categories are not visible. On the recent Ads block they are visible but when i search throw modules/classifieds/catview.php i see the category tiles and the number of Ads in that category but inside is nt showing anything. Click here and go inside a category with Ads e.g Cars, Motorcycles and Vehicles you will see what i mean.

2. On edit both the admin and users cannot modify or delete image. So when someone posts an Ad with an acceptable image there is no way to remove that a image unless to delete the whole post.

3. The number of Ads to show in block recent w/image is not adjustable its just showing 10. If i want 15 or 5 or 20 its not working.

Please assist ASAP.

Thanks

Posted on: Yesterday 15:23
Transfer the post to other applications Transfer


john
Re: City,State not showing up? 4.1 upgrade.
#8
Webmaster
Joined:
2004/10/6 16:13
Posts: 832
Offline
Sorry I didn't get a chance to call you, I was busy all weekend trying to get version 4.2 released. I am almost finished, just a couple things giving me trouble. Version 4.2 has fixes to everything reported plus I broke down a few pages, like the index page, modjobs, editcomp. I have been wanting to do this for a while and it was the right time this weekend. Hopefully it will be out by Wednesday at the latest.


Thanks,

John

Posted on: 3/8 7:13
Transfer the post to other applications Transfer


eventspeak
City,State not showing up? 4.1 upgrade.
#9
Zoner
Joined:
2004/10/6 16:13
Posts: 55
Offline
Hi john, sorry i have been so distant but life has been crazzzyyy...

So i was recently hacked and now forced to upgrade all my mods..

I upgraded the job mod and the only issue i see is that city and state does not appear under location on the main page. any ideas.

call me if you want im off today. (first day off in a while.. lol)

james T. 9548126019

Posted on: 3/6 13:45
Transfer the post to other applications Transfer


john
Re: JOBS 4.1 : I can not add a resume
#10
Webmaster
Joined:
2004/10/6 16:13
Posts: 832
Offline
That code is wrong, sorry.

Try this

$lid = intval($_POST['lid']);

if not try this

$lid = intval($_GET('lid']);


John

Posted on: 3/6 10:08
Transfer the post to other applications Transfer



 Top
(1) 2 3 4 ... 200 »




Donat-O-Meter
Make donations with PayPal!
Donations
Waiting Contents Ext
System Downloads Forum Alumni classifieds Job Listings Garages
Weather
Southington
Conditions as of
29 minutes ago

mostly cloudy
Temp: 52 °F ↓
Rel hum: 35 % ↑
Wind increasing
S at 6.9 mph
view forecast
jlmzone © 2010
Powered by XOOPS 2.4.4